Add Eio.Pool.use ~never_block #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrondin
force-pushed
the
pool-never-block
branch
from
fcda90c
to
a65ab7b
Compare
SGrondin
force-pushed
the
pool-never-block
branch
2 times, most recently
from
c1e0aa1
to
c91cf5c
Compare
talex5
force-pushed
the
pool-never-block
branch
2 times, most recently
from
5b4abc9
to
dbb74d3
Compare
talex5
reviewed
Mar 18, 2024
lib_eio/pool.ml
Outdated
| | false when never_block -> | ||
| (* We are at capacity, but cannot block. | ||
| Create a new resource to run f but don't add it to the pool. *) | ||
| Atomic.set cell Finished; |
There was a problem hiding this comment.
This isn't quite right. The cell might contain a Resource by now. If so, we should use that.
(probably needs an Atomic.exchange cell Finished here)
There was a problem hiding this comment.
Thanks, I'll fix it this weekend if you don't get to it first
There was a problem hiding this comment.
Pushed. I have a remaining question for you that I'm keeping for the devs meeting, so I think merging this PR should wait until after the meeting.
SGrondin
force-pushed
the
pool-never-block
branch
from
dbb74d3
to
029e15a
Compare
talex5
force-pushed
the
pool-never-block
branch
from
029e15a
to
321bc09
Compare
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
May 28, 2024
CHANGES: New features: - Add `Eio.Path.symlink` (@patricoferris ocaml-multicore/eio#715, reviewed by @talex5). - Add `Eio.Pool.use ~never_block` (@SGrondin ocaml-multicore/eio#657, reviewed by @talex5). - Add `Eio_unix.Net.import_socket_listening` (@alyssais ocaml-multicore/eio#733). - Add `Eio.Time.Timeout.sleep` (@talex5 ocaml-multicore/eio#726). Documentation: - Add `examples/fs` showing how to walk a directory tree (@talex5 ocaml-multicore/eio#730). - README: explain that `read_all` reads until shutdown (@talex5 ocaml-multicore/eio#717, reported by @Wenke-D). - Use long dash in README title (@lucperkins ocaml-multicore/eio#718). Linux backend: - Require Linux >= 5.15 (@talex5 ocaml-multicore/eio#720, reviewed by @SGrondin and @avsm). Removes a work-around that required checking whether every flow was a tty. - Don't call submit immediately before wait (@talex5 ocaml-multicore/eio#728). This is slightly faster and makes the traces clearer. - Don't record submit events when there's nothing to submit (@talex5 ocaml-multicore/eio#729). Makes the traces a bit clearer. - Split flow into its own file (@talex5 ocaml-multicore/eio#727). - Add work-around for signals race (@talex5 ocaml-multicore/eio#734). POSIX backend: - Add `_BSD_SOURCE` flag to fix build on OpenBSD (@prgbln ocaml-multicore/eio#722). - Fix sandboxed path resolution on OpenBSD (@jebrosen ocaml-multicore/eio#723, reviewed by @talex5). OpenBSD uses `ELOOP` when opening a symlink with `O_NOFOLLOW`. Build and test: - Benchmarks: record uname, Eio backend, and number of cores (@talex5 ocaml-multicore/eio#719). - Update to MDX 2.4.1 for OCaml 5.2 (@talex5 ocaml-multicore/eio#712).
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
May 28, 2024
CHANGES: New features: - Add `Eio.Path.symlink` (@patricoferris ocaml-multicore/eio#715, reviewed by @talex5). - Add `Eio.Pool.use ~never_block` (@SGrondin ocaml-multicore/eio#657, reviewed by @talex5). - Add `Eio_unix.Net.import_socket_listening` (@alyssais ocaml-multicore/eio#733, reviewed by @talex5). - Add `Eio.Time.Timeout.sleep` (@talex5 ocaml-multicore/eio#726). Documentation: - Add `examples/fs` showing how to walk a directory tree (@talex5 ocaml-multicore/eio#730). - README: explain that `read_all` reads until shutdown (@talex5 ocaml-multicore/eio#717, reported by @Wenke-D). - Use long dash in README title (@lucperkins ocaml-multicore/eio#718). Linux backend: - Require Linux >= 5.15 (@talex5 ocaml-multicore/eio#720, reviewed by @SGrondin and @avsm). Removes a work-around that required checking whether every flow was a tty. - Don't call submit immediately before wait (@talex5 ocaml-multicore/eio#728). This is slightly faster and makes the traces clearer. - Don't record submit events when there's nothing to submit (@talex5 ocaml-multicore/eio#729). Makes the traces a bit clearer. - Split flow into its own file (@talex5 ocaml-multicore/eio#727). - Add work-around for signals race (@talex5 ocaml-multicore/eio#734). POSIX backend: - Add `_BSD_SOURCE` flag to fix build on OpenBSD (@prgbln ocaml-multicore/eio#722). - Fix sandboxed path resolution on OpenBSD (@jebrosen ocaml-multicore/eio#723, reviewed by @talex5). OpenBSD uses `ELOOP` when opening a symlink with `O_NOFOLLOW`. Build and test: - Benchmarks: record uname, Eio backend, and number of cores (@talex5 ocaml-multicore/eio#719). - Update to MDX 2.4.1 for OCaml 5.2 (@talex5 ocaml-multicore/eio#712).
avsm
pushed a commit
to avsm/opam-repository
that referenced
this pull request
Sep 5, 2024
CHANGES: New features: - Add `Eio.Path.symlink` (@patricoferris ocaml-multicore/eio#715, reviewed by @talex5). - Add `Eio.Pool.use ~never_block` (@SGrondin ocaml-multicore/eio#657, reviewed by @talex5). - Add `Eio_unix.Net.import_socket_listening` (@alyssais ocaml-multicore/eio#733, reviewed by @talex5). - Add `Eio.Time.Timeout.sleep` (@talex5 ocaml-multicore/eio#726). Documentation: - Add `examples/fs` showing how to walk a directory tree (@talex5 ocaml-multicore/eio#730). - README: explain that `read_all` reads until shutdown (@talex5 ocaml-multicore/eio#717, reported by @Wenke-D). - Use long dash in README title (@lucperkins ocaml-multicore/eio#718). Linux backend: - Require Linux >= 5.15 (@talex5 ocaml-multicore/eio#720, reviewed by @SGrondin and @avsm). Removes a work-around that required checking whether every flow was a tty. - Don't call submit immediately before wait (@talex5 ocaml-multicore/eio#728). This is slightly faster and makes the traces clearer. - Don't record submit events when there's nothing to submit (@talex5 ocaml-multicore/eio#729). Makes the traces a bit clearer. - Split flow into its own file (@talex5 ocaml-multicore/eio#727). - Add work-around for signals race (@talex5 ocaml-multicore/eio#734). POSIX backend: - Add `_BSD_SOURCE` flag to fix build on OpenBSD (@prgbln ocaml-multicore/eio#722). - Fix sandboxed path resolution on OpenBSD (@jebrosen ocaml-multicore/eio#723, reviewed by @talex5). OpenBSD uses `ELOOP` when opening a symlink with `O_NOFOLLOW`. Build and test: - Benchmarks: record uname, Eio backend, and number of cores (@talex5 ocaml-multicore/eio#719). - Update to MDX 2.4.1 for OCaml 5.2 (@talex5 ocaml-multicore/eio#712).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the optional parameter
?never_block:booltoEio.Pool.use. The default isfalse.Quoting
pool.mli:In my opinion, this feature makes
Eio.Poola valid choice for a wider range of use cases.