Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Named Lin.Cmd and Lin.Elem arguments #292

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Named Lin.Cmd and Lin.Elem arguments #292

merged 1 commit into from
Feb 9, 2023

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Feb 1, 2023

This PR is from @art-w's #266.
It names the individual components of Lin.Cmd and Lin.Elem which is a good idea(:tm:) independently of #266's proposed optimization.

Thanks @art-w! 😃🙏

@jmid jmid mentioned this pull request Feb 1, 2023
Open
@jmid
Copy link
Collaborator Author

jmid commented Feb 3, 2023

CI summary (no errors related to the PR):

  • 1 Windows trunk Dynlink crash
  • 1 Windows trunk bytecode threadomain timeout
  • 1 Windows 5.0.0 excessive Lin Out_channel shrinking causing timeout

@jmid jmid merged commit 49af125 into main Feb 9, 2023
@jmid jmid deleted the art-w-named-args branch February 9, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmid @art-w