Fix bounded queue example to use Condition.broadcast
#185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `Condition.signal` is not correct in these cases, because it is possible that multiple fibers manage to start `Condition.wait` and a single `Condition.signal` does not wake up all of them. Another alternative would be to `Condition.signal` every time the queue is not empty or is not full.
polytypic
force-pushed
the
fix-bounded_q-example
branch
from
609667e to
e5c474e
Compare
polytypic
commented
Jul 22, 2024
| winner := 3); | ||
| (fun () -> | ||
| Control.sleep ~seconds:0.5; | ||
| Control.sleep ~seconds:1.5; |
There was a problem hiding this comment.
Timeout increased to reduce flakiness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Condition.signalis not correct in these cases, because it is possible that multiple fibers manage to startCondition.waitand a singleCondition.signaldoes not wake up all of them. Another alternative would be toCondition.signalevery time the queue is not empty or is not full.