opam-web.sh: append the redirect to the repo file, instead of replacing the entire file #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the entire file
This was referenced May 29, 2024
kit-ty-kate
reviewed
May 29, 2024
| browse: "https://${BASEURL}/pkg/" | ||
| upstream: "https://github.com/ocaml/opam-repository/tree/master/" | ||
| # Append to the 'repo' file, and dispatch all non-standard versions | ||
| cat <<EOF >>repo |
There was a problem hiding this comment.
Suggested change
| cat <<EOF >>repo | |
| sed -i 's/^browse: /d' repo | |
| cat <<EOF >>repo | |
| browse: "https://${BASEURL}/pkg/" |
There was a problem hiding this comment.
but why? In opam-repository the browse points to https://opam.ocaml.org/pkg (and aside, what is browse used for?)
There was a problem hiding this comment.
and aside, what is browse used for?
no idea. @rjbou do you know what it's used for?
There was a problem hiding this comment.
FWIW, https://opam.ocaml.org/pkg/ returns an empty page (404, Not found). In the opam sources, there's nothing using the browse from OpamFile.RepoSyntax. From the Manual.md: * <a id="repofield-browse">`browse: <string>`</a>: An URL where the users may browse available packages online
kit-ty-kate
approved these changes
May 29, 2024
|
now live after testing it on staging.opam.ocaml.org (sorry for the delay i was at EMF) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//cc @kit-ty-kate -- this should do the trick, or shouldn't it?