Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes bug in bc91e42246a7fe184377ab650f66f629e8e378be #2455

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Fixes bug in bc91e42246a7fe184377ab650f66f629e8e378be #2455

merged 4 commits into from
Oct 5, 2023

Conversation

EmileTrotignon
Copy link
Collaborator

This fixes a bug that was introduced in commit bc91e42 (pr #2451 )

The test shown was formatted the following way :

module rec A : A = struct end

(** about b *)
and  (** floatting *) B : B = struct end

Julow
Julow reviewed Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice detective work!

You can mention this PR in the same change entry as #2451

test/passing/tests/rec_str_item_comment.ml Outdated Show resolved Hide resolved
Julow
Julow approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I'll merge when the CI is green.

@Julow Julow merged commit ab3b75b into ocaml-ppx:main Oct 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julow Julow Julow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmileTrotignon @Julow