Merge pull request #496 from Octachron/stabler_special_function

Context_free: add a special_function' variant

CHANGES.md

@@ -4,6 +4,10 @@ unreleased
 - Fix `Longident.parse` so it also handles indexing operators such as
   `.!()`, `.%(;..)<-`, or `Vec.(.%())` (#494, @octachron)
 
+- Add a `special_function'` variant which directly takes a `Longident.t`
+  argument to avoid the issue that `Longident.t` cover distinct syntaxic classes
+  which cannot be easily parsed by a common parser (#496, @octachron).
+
 0.32.1 (2024-04-23)
 -------------------
 

src/context_free.ml

@@ -130,6 +130,9 @@ module Rule = struct
   let special_function id f =
     T (Special_function, { name = id; ident = Longident.parse id; expand = f })
 
+  let special_function' ident f =
+    T (Special_function, { name = Longident.name ident; ident; expand = f })
+
   let constant kind suffix expand = T (Constant, { suffix; kind; expand })
 
   let attr_str_type_decl attribute expand =

src/context_free.mli

@@ -19,14 +19,18 @@ module Rule : sig
   (** Rewrite an extension point *)
 
   val special_function : string -> (expression -> expression option) -> t
+
+  val special_function' : Longident.t -> (expression -> expression option) -> t
   (** [special_function id expand] is a rule to rewrite a function call at
       parsing time. [id] is the identifier to match on and [expand] is used to
       expand the full function application (it gets the Pexp_apply node). If the
       function is found in the tree without being applied, [expand] gets only
       the identifier (Pexp_ident node) so you should handle both cases.
 
       If [id] is an operator identifier and contains dots, it should be
-      parenthesized (e.g. ["(+.+)"]).
+      parenthesized (e.g. ["(+.+)"]). Another option is to use the
+      [special_function'] variant which takes directly a {!Longident.t}
+      argument.
 
       [expand] must decide whether the expression it receive can be rewritten or
       not. Especially ppxlib makes the assumption that [expand] is idempotent.