Fix a bug in bench that was running the driver on dune generated folders #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanReb
added
the
no changelog
NathanReb
requested review from
ceastlund,
panglesd and
pitag-ha
as code owners
NathanReb
force-pushed
the
fix-benchmarks
branch
from
287cdb2 to
89bdbde
Compare
panglesd
reviewed
Feb 8, 2024
There was a problem hiding this comment.
There is another call to readdir_full_path, don't we want to also filter dot files there?
I guess so, in which case it would be better to modify readdir_full_path to filter the dot files. It would also allow to avoid calling Filename.concat followed by Filename.basename!
Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
force-pushed
the
fix-benchmarks
branch
from
89bdbde to
dcac2eb
Compare
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.