Simplify expect tests #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
requested review from
ceastlund,
panglesd and
pitag-ha
as code owners
NathanReb
added
the
no changelog
|
I should've opened this as draft, I wanted to see the CI run to test the 5.1.0 thing and make sure it was working alright! |
|
It seems to be working fine! This should be ready to review! |
Signed-off-by: Nathan Rebours <[email protected]>
|
There is something incredibly fishy going on here, even with the trimming we end up with a leading empty line in some cases. I'll look into it! |
NathanReb
force-pushed
the
simplify-deriving-test
branch
from
410c26c to
153e457
Compare
|
Got it, errors are reported by another printer, I'll try fixing this one as well! |
Signed-off-by: Nathan Rebours <[email protected]>
Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
force-pushed
the
simplify-deriving-test
branch
from
153e457 to
117ee2c
Compare
|
Let's wait for the CI but I fixed the error reporting as well and manually tested it on 5.1.1 so it should be good this time. |
panglesd
approved these changes
Feb 7, 2024
Signed-off-by: Nathan Rebours <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that in 5.1.0 the output of the toplevel was sometime prefixed with an empty line and that led us to have seperate expect test output reference files for 5.1.0.
This PR slightly modifies the expect test runner to trim the toplevel output, getting rid of said lines on the way.
There is also a small bonus: I'm suggesting a rewriting of one of the deriving test so it relies on a positive output of the toplevel rather than on error reporting from the compiler. I maybe lacking context but it seems to me the two test are equivalent and the updated one won't trigger a failure due to what appears to be a change in the error reporting in OCaml 5.2.
Please let me know what you think!