Insert caught exception in place of the rewritten or generated item #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanReb
requested review from
ceastlund,
panglesd and
pitag-ha
as code owners
When a context free rule raises, the exception was caught and turned into an error extension node prepended to the whole AST. This changes this behaviour to instead insert the error extension where the generated code would be, had the rule not raised. Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
force-pushed
the
insert-context-free-exception
branch
from
17a7fd5 to
667c002
Compare
Signed-off-by: Nathan Rebours <[email protected]>
Signed-off-by: Nathan Rebours <[email protected]>
|
Fixed the build failure and enabled this behaviour for special functions and constants as well! |
panglesd
approved these changes
Feb 13, 2024
| | EC.Signature_item -> Ast_builder.Default.psig_extension ~loc extension [] | ||
| | EC.Structure_item -> Ast_builder.Default.pstr_extension ~loc extension [] | ||
| | EC.Ppx_import -> | ||
| (* Insert the error in the type decl manifest *) |
There was a problem hiding this comment.
We've had the same idea 🙂
This function could be in extension.ml, in my opinion, but I'm not even sure and that might be bikeshedding: feel free to ignore the suggestion...
There was a problem hiding this comment.
I moved it in context_free because putting it in extension meant to make it public and I'm not sure we want to.
It is also only used for errors and is therefore very specific.
NathanReb
added a commit
to NathanReb/opam-repository
that referenced
this pull request
Apr 23, 2024
CHANGES: - Add support for OCaml 5.2 - Insert errors from caught located exceptions in place of the code that should have been generated by context-free rules. (ocaml-ppx/ppxlib#472, @NathanReb)
NathanReb
added a commit
to NathanReb/opam-repository
that referenced
this pull request
Apr 23, 2024
CHANGES: - Add support for OCaml 5.2 - Insert errors from caught located exceptions in place of the code that should have been generated by context-free rules. (ocaml-ppx/ppxlib#472, @NathanReb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should wrap up the work on #448 !
When a context free rule raises, the exception was caught and turned into an error extension node prepended to the whole AST. This changes this behaviour to instead insert the error extension where the generated code would be, had the rule not raised.