Make -unused-code-warning tests actual tests #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In their previous form they were not executed as part of the default build or as part of the runtest alias. They relied on a deriving_inline workflow which wasn't great for tests and it lacked a bit of context on what was being tested so I converted them to cram tests. It's a bit harder to read the generated code than it was but the whole setup is not spread across 3 different directories anymore and the tests are now documented. Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
added
the
no changelog
|
I'm not sure what the CC @ceastlund maybe you know a bit more about this. |
patricoferris
approved these changes
Jun 3, 2024
Signed-off-by: Nathan Rebours <[email protected]>
patricoferris
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In their previous form they were not executed as part of the default build or as part of the runtest alias.
They relied on a deriving_inline workflow which wasn't great for tests and it lacked a bit of context on what was being tested so I converted them to cram tests. It's a bit harder to read the generated code than it was but the whole setup is not spread across 3 different directories anymore and the tests are now documented.