Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to OCamlformat 0.27.0 #534

Closed

Conversation

Julow
Copy link

@Julow Julow commented Oct 30, 2024

The aim of this preview is to gather feedback.

Changelog can be found here: https://github.com/ocaml-ppx/ocamlformat/blob/main/CHANGES.md

@Julow Julow marked this pull request as draft October 30, 2024 17:43
Copy link
Collaborator

@NathanReb NathanReb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new formatting much better ! Awesome work!

src/context_free.ml Show resolved Hide resolved
@Julow Julow force-pushed the preview-ocamlformat-0.27.0-preview1 branch from bc6ce1e to 9fccb79 Compare November 28, 2024 10:14
@NathanReb NathanReb added the no changelog Use this label to disable the changelog check github action label Nov 28, 2024
Julow added 2 commits December 6, 2024 13:41
Signed-off-by: Jules Aguillon <[email protected]>
Signed-off-by: Jules Aguillon <[email protected]>
@Julow Julow force-pushed the preview-ocamlformat-0.27.0-preview1 branch from 9fccb79 to e7cb6c1 Compare December 6, 2024 12:42
@Julow Julow changed the title Preview ocamlformat 0.27.0 preview1 Upgrade to OCamlformat 0.27.0 Dec 6, 2024
@Julow Julow marked this pull request as ready for review December 6, 2024 12:50
@Julow
Copy link
Author

Julow commented Dec 6, 2024

OCamlformat 0.27.0 as been released 🎉 This is ready to be merged.

@NathanReb
Copy link
Collaborator

Thanks @Julow ! I'll merge the urgent PRs and will rebase this!

@Julow
Copy link
Author

Julow commented Dec 18, 2024

Thanks for looking at the diffs :) I'll close this PR as it's not easily rebased and it's better if the upgrade is done by a maintainer.

@Julow Julow closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Use this label to disable the changelog check github action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants