Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Improve deriving inline so it can be used alongside other ppx-es #541

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

NathanReb
Copy link
Collaborator

No description provided.

@NathanReb
Copy link
Collaborator Author

CC @mbarbin you should be able to try this out for your usecase, simply add the -no-corrections to your (preprocess (pps ...)) field and it will not require that you add the ppx-es you only use with deriving_inline and won't generate corrections during builds anymore.

This is still WIP as I'm trying to tie all loose ends but it should already be usable for common use cases.

@NathanReb NathanReb force-pushed the improve-deriving-inline branch from b51d33e to 4b77038 Compare December 9, 2024 09:49
@mbarbin
Copy link
Contributor

mbarbin commented Dec 10, 2024

Hi @NathanReb I wanted to let you know that it will take me a bit of time to get back to you on this, but I am excited to try it out as soon as I get a chance. Thank you for your work on this!

@mbarbin
Copy link
Contributor

mbarbin commented Dec 16, 2024

@NathanReb I tried it in this PR => mbarbin/vcs#32 and commented there directly. To summarize what I got:

  • ✅ The build works
  • ✅ The doesn't round-trip errors are gone
  • ❌ The lint current fails with small auto-formatting issues

So, this is definitely a lot of progress, and possibly very close to working! Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants