Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing functions to pprintast (binding, longindent, payload) #542

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Add missing functions to pprintast (binding, longindent, payload) #542

merged 2 commits into from
Dec 10, 2024

Conversation

mattiasdrp
Copy link
Contributor

Fixes #531

@mattiasdrp mattiasdrp mentioned this pull request Dec 6, 2024
Closed
@NathanReb
Copy link
Collaborator

Thanks your contribution!

Could you rebase on top of main with the --signoff flag to make the DCO check happy? This should also fix the unrelated CI failures!

@mattiasdrp mattiasdrp force-pushed the add-missing-pprintast-functions branch from 7934d8a to 4cf525e Compare December 9, 2024 14:51
@mattiasdrp
Copy link
Contributor Author

Done!

NathanReb
NathanReb approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@NathanReb NathanReb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just added the changelog entry to save you the trouble. I'll merge when the CI's green again.

@NathanReb NathanReb merged commit f15df48 into ocaml-ppx:main Dec 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanReb NathanReb NathanReb approved these changes

@ceastlund ceastlund Awaiting requested review from ceastlund ceastlund is a code owner

@panglesd panglesd Awaiting requested review from panglesd panglesd is a code owner

@patricoferris patricoferris Awaiting requested review from patricoferris patricoferris is a code owner

@pitag-ha pitag-ha Awaiting requested review from pitag-ha pitag-ha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Three functions are missing from pprintast
2 participants
@mattiasdrp @NathanReb