Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add ppx-by-example #544

Closed

Conversation

pedrobslisboa
Copy link

@pedrobslisboa pedrobslisboa commented Dec 9, 2024

Warning

This is a work-in-progress branch
Be careful on reviewing it as it's not ready for it

Description

This is the first PR of the movement of adding the examples of ppx-by-example to ppxlib

Todo

  • Add test section
  • Separe this branch into smaller ones

* main: (22 commits)
  Remove vendored ppx_sexp_conv opam file
  Avoid duplication in gen_ast_builder
  Only pass type declaration once to gen_combinator_for_record
  Simplify type variable reconstruction
  Changelog entry
  Explicitly construct ast_builder floating comments
  Add sections and parsetree docs to ast_builder
  Refactor ast_builder to add documentation comments
  Support class type declarations in derivers
  Add configured and configurable printer types to Pp_ast
  Add Submodules with simpler APIs to Pp_ast
  Bring expect_in version ranges in line with opam notations
  Add [%%ignore] to expect_test runner and fix quoter tests
  Add support for single version [%%expect_in]
  Use [%%expect_in to make test pass under 5.3
  Make expect test runner compatible with 5.3+ again
  Make new [%%expect_in syntax compatible with ocamlformat
  Add versioned expect block to expect test runner
  Fix out of date test
  Replace -dparsetree sexp output with a pretty-printed AST
  ...
@NathanReb NathanReb added the no changelog Use this label to disable the changelog check github action label Dec 10, 2024
@pedrobslisboa
Copy link
Author

Closing this PR in favor of: #545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Use this label to disable the changelog check github action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants