Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Apply @config on module structs and signatures #18

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Feature: Apply @config on module structs and signatures #18

merged 4 commits into from
Apr 24, 2024

Conversation

KFoxder
Copy link
Contributor

@KFoxder KFoxder commented Apr 18, 2024

Overview

  • Addresses issue / feature: Support @@cfg within module & signatures #3
  • Allows use of @cfg on module structs and signatures
  • Added cram test cases for module structs and signatures
  • Added cram tests for the interface files as well which was missing

TODO

  • Update documentation to show uses in cases and feature branches

@KFoxder KFoxder mentioned this pull request Apr 18, 2024
Merged
leostera
leostera reviewed Apr 24, 2024
View reviewed changes
config/ppx.t/cond_module.ml
[@@config (made_up = true)]
module B:A = struct
let best_band_in_the_world = "RUSH" [@@cfg (value = "1")]
let worst_band_in_the_world = "Nickelback" [@@cfg (value = "2")]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha poor nickelback

@leostera leostera merged commit c9a92a1 into ocaml-sys:main Apr 24, 2024
2 checks passed
@leostera
Copy link
Collaborator

Thanks for the PR @KFoxder! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leostera leostera leostera left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KFoxder @leostera