Bigstring performance optimizations #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vouillon
force-pushed
the
bigstring-perfs
branch
2 times, most recently
from
974eac7
to
b656ca6
Compare
vouillon
force-pushed
the
bigstring-perfs
branch
2 times, most recently
from
6f790a7
to
292b7be
Compare
vouillon
force-pushed
the
main
branch
3 times, most recently
from
a74ffbb
to
058036f
Compare
This makes it visible to binaryen, which than is able to eliminate so unncessary boxing.
Calling a JavaScript function is costly. This reduces the number of calls to a JavaScript function that we need to make to get or set a 16-bit or 32-bit integer.
vouillon
force-pushed
the
bigstring-perfs
branch
from
292b7be
to
c3ba995
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.