Integrate "Target-specific code" (ocsigen/js_of_ocaml#1655) #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Olivier Nicole <[email protected]> Co-authored-by: Jérôme Vouillon <[email protected]> Co-authored-by: Hugo Heuzard <[email protected]>
vouillon
reviewed
Oct 1, 2024
OlivierNicole
force-pushed
the
converge-jsoo-merge-08
branch
from
9b7d1ef
to
af34f71
Compare
vouillon
reviewed
Oct 1, 2024
|
The type of |
|
|
OlivierNicole
force-pushed
the
converge-jsoo-merge-08
branch
from
cd76621
to
a6c1ee5
Compare
|
That should be fixed. |
OlivierNicole
force-pushed
the
converge-jsoo-merge-08
branch
from
a6c1ee5
to
509636e
Compare
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integrates PRs ocsigen/js_of_ocaml#1655 and its small preliminary PR ocsigen/js_of_ocaml#1692. The two subsequent commits make the necessary changes in the code of wasm_of_ocaml.