Generate "_CoqProject" files for Coq theories #11752
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rodolphe Lepigre <[email protected]>
|
@ejgallego any chance you could take a look at this? |
|
Yes @rlepigre , I'm almost at the point I will resume work on Dune Rocq; thanks for your patience. |
|
Looks pretty good to me, I have some minor comments, but I suggest to add a changelog and documentation, as I can fix the comments myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept for something @ejgallego and I discussed in the past as an alternative to using
dune coq topfor editors. We generate one_CoqProjectfile for eachcoq.theorystanza, which should allow good support across editors for stepping through Coq/Rocq source files.This is incompatible with the following features, which I see as non-essential (i.e., could be removed IMO):
coq.theorystanza in a given directory.coq.theorystanza.If we want to push this through, we might want a way to disable generation of
_CoqProjectby supporting something like(project_file false)in thecoq.theorystanza.