test: fix utop tests #11771
Open
test: fix utop tests #11771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
ps/rr/test__fix_utop_tests
branch
2 times, most recently
from
b9313a5 to
abd4a55
Compare
Leonidas-from-XIV
force-pushed
the
ps/rr/test__fix_utop_tests
branch
from
abd4a55 to
26574e6
Compare
|
I was worried that the test never terminates on Linux because so far it has been stuck for hours running the Github Action, but it works just fine on my Linux machine. |
|
@Leonidas-from-XIV Which kernel version do you have? I'm on 6.14.2 and I cannot reproduce. The GH actions ubuntu runners have been using |
rgrinberg
force-pushed
the
ps/rr/test__fix_utop_tests
branch
from
26574e6 to
c298e05
Compare
|
I think the correct fix is |
|
Could you push the fix to this PR then? |
|
It won't work on 5.3 since the |
rgrinberg
force-pushed
the
ps/rr/test__fix_utop_tests
branch
from
c298e05 to
2c4b736
Compare
Signed-off-by: Rudi Grinberg <[email protected]> <!-- ps-id: ad13c693-c903-495c-9b2c-3c8cf6212119 --> Signed-off-by: Rudi Grinberg <[email protected]>
rgrinberg
force-pushed
the
ps/rr/test__fix_utop_tests
branch
from
2c4b736 to
9087df8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rudi Grinberg [email protected]