Skip to content

Reproduction case for #11824 #11825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Leonidas-from-XIV
Copy link
Collaborator

This PR adds a test to show that portable lockfiles currently don't output the depexts correctly.

I looked into the lockfiles and the depexts are recorded correctly, it's just show depext which doesn't resolve them.

@gridbugs
Copy link
Collaborator

I understand why this happens. Dune currently only records depexts into lockfiles for platforms that it solves for rather than all the platforms listed in the opam file. I think for depexts it might make sense to record all the metadata from the opam file into the lockfile, since the choice of depexts is often more specific than dependencies. For example for the more obscure linux distributions it's probably fine to solve dependencies without considering os-distribution or os-version, however the choice of depexts usually requires considering these fields.

I'll explore an alternative way of recording depexts that preserves all the information about depexts in the opam file.

@Leonidas-from-XIV
Copy link
Collaborator Author

Yes, that explains very well why the repro test for the bug passes on my machine (Fedora) while it fails (aka, the behavior is correct) on CI (which presumably uses something Debian-like).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants