pkg: include sys_ocaml_version in solver env #11935
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a problem when using the "ocaml-system" compiler package and setting the "sys-ocaml-version" variable in the solver environment. Without including sys_ocaml_version in the solver environment at build time, the presence of sys_ocaml_version in the solver environment recorded in the lockdir causes dune to incorrectly believe that the solver environment is incompatible with the current system, even if the version of the currently-installed system compiler is the same as the one in the solver environment recorded in the lockdir. Signed-off-by: Stephen Sherratt <[email protected]>
|
This has been subsumed by #11933. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem when using the "ocaml-system" compiler package and setting the "sys-ocaml-version" variable in the solver environment. Without including sys_ocaml_version in the solver environment at build time, the presence of sys_ocaml_version in the solver environment recorded in the lockdir causes dune to incorrectly believe that the solver environment is incompatible with the current system, even if the version of the currently-installed system compiler is the same as the one in the solver environment recorded in the lockdir.