-
Notifications
You must be signed in to change notification settings - Fork 452
[draft][OxCaml] Tutorial for library parameter #12111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Etienne Marais <[email protected]> Signed-off-by: Etienne Marais <[email protected]>
Signed-off-by: Etienne Marais <[email protected]>
Signed-off-by: Etienne Marais <[email protected]>
Signed-off-by: Etienne Marais <[email protected]>
5732b55 to
0106436
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm reading through this with the intention of taking it over from @maiste (thanks for all the hard work!). Leaving some notes below.
| Parameterized library in Dune are a concept similar to | ||
| {doc}`/virtual-libraries`. Parameterized libraries are the formalization within | ||
| the compiler of virtual libraries.A parameterized library is conceptually | ||
| equivalent to a functor. For more detailled explanation, see (TODO @maiste: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it meant to link some documentation about parameterized libraries? Is it available somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes 👍🏻
|
@maiste is it ok if I push to this branch directly? |
|
Yes it that exactly the purpose of this PR 😄 |
Signed-off-by: Sudha Parimala <[email protected]>
This PR is not ready for review. It is a way to share with @art-w the advancement regarding the documentation of library_parameter.
The tutorial aims to follow a simple flow to go through all the possibilities provided by parameterized libraries. It covers the entire "diamond" of the parameterized library, i.e.:
Right now, the PR covers:
The remaining part are:
The rest of the work is subject to modification as it is currently the first draft.