fix: avoid killing process group when not applicable #12360
Draft
+28
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
force-pushed
the
dune-exec-watch-server
branch
2 times, most recently
from
7f1ffff to
e61a2dd
Compare
This was referenced Aug 30, 2025
Alizter
force-pushed
the
dune-exec-watch-server
branch
from
e61a2dd to
de9aff5
Compare
|
I don't think we should have any "fallbacks". If we are launching a process without a process group, we know we are doing that and there's no need to send a signal to the group |
|
Sounds good to me. I will need to design a more principled solution that tracks the process group as you said. It might take some time before I can get round to it however. |
Alizter
force-pushed
the
dune-exec-watch-server
branch
from
de9aff5 to
00984fe
Compare
Alizter
changed the title
|
💥 I've messed up |
We add a way of tracking whether a job is a process group leader to the scheduler. This allows us to avoid sending a signal to a process group when it isn't needed. Doing so fixes an issue with dune exec -w where rebuilds would send a kill signal to a non-existant process group assumed to be attached to the process we were execing. Signed-off-by: Ali Caglayan <[email protected]>
Alizter
force-pushed
the
dune-exec-watch-server
branch
from
00984fe to
ca5f086
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a way of tracking whether a job is a process group leader to the
scheduler. This allows us to avoid sending a signal to a process group
when it isn't needed.
Doing so fixes an issue with dune exec -w where rebuilds would send a
kill signal to a non-existant process group assumed to be attached to
the process we were execing.