Skip to content

Conversation

Alizter
Copy link
Collaborator

@Alizter Alizter commented Sep 12, 2025

I'm not certain if we need to version guard this since it was buggy behaviour before.

  • changelog
  • don't break enabled_if

@Alizter Alizter requested a review from rgrinberg September 12, 2025 15:38
Copy link
Member

@rgrinberg rgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix breaks enabled_if

@Alizter Alizter marked this pull request as draft September 12, 2025 18:09
@Alizter
Copy link
Collaborator Author

Alizter commented Sep 13, 2025

@rgrinberg I am not sure what you mean by that. AFAICT the only breakage is because we have people doing:

(tests
 (names foo))
(tests
 (names bar))

I'm not sure if it makes sense to check for overlapping modules in this case. We could get around this by introducing a version guard for the check, but does it even make sense to fix this? Perhaps this is a non-fix and really the missing cmi message needs another fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants