refactor(boot): simplify handling of architecture values. #12469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
force-pushed
the
push-qmnowlwzlnrp
branch
from
aaf5a0a to
fb6edd7
Compare
When we parse this as a string, we can squash it down rather than having to double check later. Signed-off-by: Ali Caglayan <[email protected]>
We unify the type of architectures which allows us to simplify some of the conditional compilation based on architecture. Signed-off-by: Ali Caglayan <[email protected]>
Alizter
force-pushed
the
push-qmnowlwzlnrp
branch
from
fb6edd7 to
096fc39
Compare
Alizter
force-pushed
the
push-qmnowlwzlnrp
branch
from
8527f0d to
096fc39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we parse architecture values from the config, we might as well collapse
amd64andx86_64since these are the same.We also simplify the various places we handle architectures to use the same (poly) variant. This allows us to simplify some other parts and share some code.