Skip to content

Commit

Permalink
Fix continuous integration (#224)
Browse files Browse the repository at this point in the history
The benchmark requires core_{bench,unix}, but we don't declare them in
opam dependencies because of loops.

core_unix requires ocaml >= 4.08.0.
  • Loading branch information
glondu authored Aug 3, 2023
1 parent 1792704 commit c498afd
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
#- macos-latest
#- windows-latest
ocaml-compiler:
- 4.03.x
- 4.08.x
- 4.14.x
runs-on: ${{ matrix.os }}
steps:
Expand All @@ -27,5 +27,6 @@ jobs:
- run: opam pin -n .
- run: opam depext -yt re
- run: opam install -t . --deps-only
- run: opam install -y core_bench core_unix
- run: opam exec -- dune build
- run: opam exec -- dune runtest
2 changes: 1 addition & 1 deletion benchmarks/benchmark.ml
Original file line number Diff line number Diff line change
Expand Up @@ -163,4 +163,4 @@ let benchmarks =
|> Bench.Test.create_group ~name:"tex gitignore"
] @ [http_benches]

let () = Command.run (Bench.make_command benchmarks)
let () = Command_unix.run (Bench.make_command benchmarks)
2 changes: 1 addition & 1 deletion benchmarks/dune
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
(executable
(libraries re threads core_bench)
(libraries re threads core_bench core_unix.command_unix)
(name benchmark))

0 comments on commit c498afd

Please sign in to comment.