Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kludge build break when no fresh news #2878

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Kludge build break when no fresh news #2878

merged 1 commit into from
Dec 19, 2024

Conversation

cuihtlauac
Copy link
Collaborator

No description provided.

@cuihtlauac cuihtlauac requested a review from sabine December 19, 2024 08:05
@cuihtlauac cuihtlauac merged commit acd9f50 into main Dec 19, 2024
0 of 3 checks passed
@cuihtlauac cuihtlauac deleted the fix-no-news branch December 19, 2024 08:19
Copy link
Collaborator

@sabine sabine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing to FIXME here, the news feed is never going to grow too big

@@ -54,7 +54,7 @@ module RssFeed = struct
let create_feed () =
let open Rss in
all ()
|> create_entries ~create_entry ~days:90
|> create_entries ~create_entry ~days:max_int (* FIXME *)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|> create_entries ~create_entry ~days:max_int (* FIXME *)
|> create_entries ~create_entry ~days:max_int

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants