Skip to content

A more idiomatic Emacs's approach #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2025
Merged

Conversation

xvw
Copy link
Contributor

@xvw xvw commented Apr 16, 2025

The installation instructions for Emacs were a little outdated.

@xvw xvw force-pushed the ocaml-eglot-editor-setup branch from 6783b6c to 4910c00 Compare April 16, 2025 19:07
Copy link
Collaborator

@cuihtlauac cuihtlauac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor formatting changes are needed

:mode (("\\.ocamlinit\\'" . tuareg-mode)))
```

> If your version of Emacs does not support the `use-package` macro (or is not set up to take MELPA packages into account), please update it and follow these instructions to install [`use-package`](https://github.com/jwiegley/use-package) and [MELPA](https://melpa.org/#/getting-started).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quotes should be used for quotes, not highlighting. We usually have paragraph header, in bold, such as “remark”, “fun fact”, “warning”, “note” or something else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed on c1bb0be


You are now ready to edit OCaml code _productively_ with Emacs!

> OCaml-eglot can be finely configured, the project [README](https://github.com/tarides/ocaml-eglot/blob/main/README.md) gives several configuration paths to adapt perfectly to your workflow. You will also find there an exhaustive presentation of the different functions offered by the mode.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed on c1bb0be

@xvw xvw force-pushed the ocaml-eglot-editor-setup branch from 8e5b252 to c1bb0be Compare April 17, 2025 11:59
@cuihtlauac cuihtlauac self-requested a review April 17, 2025 13:14
Copy link
Collaborator

@cuihtlauac cuihtlauac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cuihtlauac cuihtlauac merged commit 305e3e6 into ocaml:main Apr 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants