Skip to content

Add GitHub Actions workflow for dune pkg #3127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Sudha247
Copy link
Contributor

This PR adds a GitHub Actions workflow for ocaml.org. This would help us catch any failures with dune pkg. Also fixed a deprecated function in Mirage_crypto_rng along the way.

@Sudha247
Copy link
Contributor Author

To add more context: This is a preliminary check whether the project builds with dune developer preview. It seems there's some issue with depext, I'll investigate this tomorrow.

@cuihtlauac
Copy link
Collaborator

Wouldn't it be more prudent to begin by a local setup allowing the use of dune pkg instead of a GitHub action?

@Sudha247
Copy link
Contributor Author

Wouldn't it be more prudent to begin by a local setup allowing the use of dune pkg instead of a GitHub action?

Indeed, and this setup was working on my machine - it was building and passing all tests. Maybe because depexts were already installed on my machine. I also discovered that it installs OCaml 4.14.x compiler version when I build it with dune pkg. Is that expected?

@sabine
Copy link
Collaborator

sabine commented May 26, 2025

Thank you Sudha, seeing that it builds on 4.14 and how little needed to be done for that was helpful. I'm closing this in favor of #3132 where I tried to get OCaml.org to work with Dune Package Management on OCaml 5.2.0 🧡

@sabine sabine closed this May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants