Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current-bench occurrence #1054

Closed
wants to merge 25 commits into from
Closed

Conversation

panglesd
Copy link
Collaborator

@panglesd panglesd commented Dec 6, 2023

This PR is just to make current-bench experimentations on #976.

OCaml Idents are unique, so there is no risk with keeping "out of scope"
idents. However, it is practical to keep the full environment at the end of a
traverse, for render source code purpose.

Signed-off-by: Paul-Elliot <[email protected]>
Signed-off-by: Paul-Elliot <[email protected]>
Signed-off-by: Paul-Elliot <[email protected]>
Signed-off-by: Paul-Elliot <[email protected]>
Some subnodes of hidden nodes were generating twice the infos

Signed-off-by: Paul-Elliot <[email protected]>
Signed-off-by: Paul-Elliot <[email protected]>
We consider as internal children of internal modules, and double underscored
roots.

Signed-off-by: Paul-Elliot <[email protected]>
Persistent and hidden occurrences can be counted, or not.

Signed-off-by: Paul-Elliot <[email protected]>
Signed-off-by: Paul-Elliot <[email protected]>
We always want to include persistents, the question is whether we want to
include the non-persistent ident!

Signed-off-by: Paul-Elliot <[email protected]>
Signed-off-by: Paul-Elliot <[email protected]>
For a fairer comparison with master in ocurrent-bench

Signed-off-by: Paul-Elliot <[email protected]>
@panglesd
Copy link
Collaborator Author

This was open just to use occurrent-bench and was never meant to be merged. Closing.

@panglesd panglesd closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant