Update ocaml/setup-ocaml to v3 #1153
Conversation
|
If I understand correctly the setup-ocaml release changelog, this setups ocaml with opam 2.2 for windows support? |
|
I added Windows, but it seems to fail due to the path delimiter, etc. |
|
You shouldn't use Fpath.to_string when generating path in dune files. |
There was a problem hiding this comment.
I think we are not ready yet to add windows testing on our CI. However, it is very nice to be able to add it so easily!
I think this is good to merge as soon as the windows-triggering line is commented out. We'll uncomment it after fixing the windows issues.
Thanks a lot for your work!
smorimoto
force-pushed
the
setup-ocaml-v3
branch
2 times, most recently
from
6e7cbaf
to
dbfca79
Compare
Signed-off-by: Sora Morimoto <[email protected]>
smorimoto
force-pushed
the
setup-ocaml-v3
branch
from
f3a8433
to
4c9d7e8
Compare
|
Ready to go! |
| @@ -1,4 +1,4 @@ | |||
| (lang dune 3.7) | |||
| (lang dune 3.16) | |||
There was a problem hiding this comment.
I think this should raise the minimal version in odoc.opam file!
| @@ -1,3 +1,3 @@ | |||
| module-item-spacing=preserve | |||
| version=0.26.1 | |||
There was a problem hiding this comment.
We should do that at some point but in a separate PR
| - 4.02.x | ||
| - 4.04.x | ||
| - 4.06.x | ||
| - 4.08.x | ||
| - 4.10.x | ||
| - 4.12.x | ||
| - 4.14.x | ||
| - 5.0.x | ||
| - 5.1.x | ||
| - 4 | ||
| - 5 |
There was a problem hiding this comment.
If I understand correctly, this runs odoc's test in 4.02 on ubuntu latest (due to the include below), and on 4.14 and the latest 5 version for linux, windows and mac.
I think it makes sense for odoc to continue checking each individual versions (4.07, 5.0 and 5.1, ...). Indeed, odoc has a lot of compatibility code for instance for the different ASTs or for the shapes, that can easily break so that we want to continue testing. (This compatibility code might work for 4.02 and 4.14 but not for an intermediate versions).
|
|
||
| - name: Install dependencies | ||
| run: opam install -y --deps-only -t ./odoc.opam ./odoc-parser.opam | ||
| run: opam install --deps-only --with-test odoc odoc-parser |
There was a problem hiding this comment.
Won't that install deps from the odoc from opam repository in case where run-mdx is true, breaking if we modify the dependencies without releasing?
No description provided.