Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset cli #1170

Merged
merged 10 commits into from
Jul 26, 2024
Merged

Asset cli #1170

merged 10 commits into from
Jul 26, 2024

Conversation

EmileTrotignon
Copy link
Collaborator

This is a draft for asset cli. It includes ability to write an asset to a file, but no way to load it afterward.

@panglesd panglesd marked this pull request as ready for review July 24, 2024 07:41
The previous saving to file did not include the root first, making the loading
fail. This commits also includes proper testing and completes lang_desc

Signed-off-by: Paul-Elliot <[email protected]>
Signed-off-by: Paul-Elliot <[email protected]>
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@panglesd panglesd merged commit e394650 into ocaml:master Jul 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants