-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line edit ocamldoc differences #1178
Line edit ocamldoc differences #1178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments inline!
You based your PR on top of #1175, which I only understood after my review.
One thing to know is that we are likely going to deleted the driver.mld file quite soon, so no need to spend too much time on it! When we rewrite it, we'll not forget to ask you for a review! 🙂
@@ -120,7 +120,7 @@ Please note: it's only necessary to link the non-hidden modules (i.e., without a | |||
{ol {- Generation: odoc html-generate | |||
}} | |||
|
|||
Once the compile and link phases are complete, the resulting [odocl] files may be rendered in a variety of formats. In this example we output HTML. | |||
Once the compile and link phases are complete, the resulting [odocl] files may be rendered in a variety of formats. In this example we output HTML: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the :
confusing. What about
Once the compile and link phases are complete, the resulting [odocl] files may be rendered in a variety of formats. In this example we output HTML: | |
Once the compile and link phases are complete, the resulting [odocl] files may be rendered in a variety of formats. In the driver exemplified in this document, we output HTML. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess my comment never sent yesterday!
That was my mistake with the:
-- I guess I saw a phantom example after it! 🙂
What about: "For the driver exemplified herein, we output HTML."
Co-authored-by: panglesd <[email protected]>
Co-authored-by: panglesd <[email protected]>
Oh no! My mistake! 😦 |
Minor line editing, mostly.