Separate commands for html generation of page+units and implementation #1188
Conversation
This has never been used and is not the way to go with odoc 3
We don't make the distinction anymore in odoc3. This also removes the --source-root argument.
| @@ -1,11 +0,0 @@ | |||
| open Or_error | |||
|
|
|||
| val compile : | |||
There was a problem hiding this comment.
The driver currently did not build source trees but this change means that the driver will have to generate regular pages in the source hierarchy.
There was a problem hiding this comment.
I think the odoc source tree mechanism is not well suited for generating source pages in the context of odoc 3. If we design a way for odoc to generate the missing pages, it would be different from the one removed here. So I think it is safe to remove it!
|
Ooh I do like a good cleanup :-) |
|
Just want to check though: should it be |
|
Also we should have some negative tests - what happens when you do |
|
In the odoc dev meeting, we decided to rename it to |
Source is now the positional argument, while impl is passed as an argument. When we generate source for other files (such as dune or .mli or Makefiles or ...) this will come handy.
This was suggested in #1185 (comment)
The benefit is cleaner man pages, safer CLI validation.
This PR also takes this opportunity to do some cleanup, by removing the old and never used way of rendering sources:
--source-rootoption which is not anymore usable in odoc 3.Once this is merged, I'll rebase #1185 on top and apply @Julow's comment!