Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver compile warnings #1323

Merged
merged 3 commits into from
Mar 3, 2025
Merged

Conversation

jonludlam
Copy link
Member

We currently only output warnings from the Link phase. This PR also outputs warnings from the compile phase, including those that come from the parser.

This PR also fixes some warnings that this change made apparent.

Copy link
Collaborator

@panglesd panglesd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jonludlam jonludlam merged commit 109f1e4 into ocaml:master Mar 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants