Span labels in function arguments (?id: and id:)
#990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbuenzli
reviewed
Aug 21, 2023
src/document/generator.ml
Outdated
|
|
||
| let tag tag t = O.span ~attr:tag t | ||
| | Odoc_model.Lang.TypeExpr.Label s -> tag "opt-arg" (O.txt s) | ||
| | Optional s -> tag "named-arg" (O.txt "?" ++ O.txt s) |
There was a problem hiding this comment.
Please avoid inventing new terminology, I'd suggest label and optlabel as per language specification.
There was a problem hiding this comment.
(Also you need to swap the names)
There was a problem hiding this comment.
Good points, thanks. I updated the PR!
panglesd
force-pushed
the
identifiers-labels-should-be-spanned
branch
from
ca69da8
to
10ae266
Compare
|
It looks like some tests are not updated, but everything else looks good to me! |
gpetiot
approved these changes
Aug 29, 2023
Julow
approved these changes
Sep 1, 2023
| @@ -89,11 +95,17 @@ <h1>Module <code><span>Type</span></code></h1> | |||
| <span><span class="keyword">type</span> labeled_higher_order</span> | |||
| <span> = | |||
| <span> | |||
| <span>(<span>l:int <span class="arrow">-></span></span> int) | |||
| <span>( | |||
There was a problem hiding this comment.
Not related to this PR but this reminds me that the --indent option breaks the formatting: ocsigen/tyxml#288
Signed-off-by: Paul-Elliot <[email protected]>
panglesd
force-pushed
the
identifiers-labels-should-be-spanned
branch
from
411cc8a
to
6a98054
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #879.
If someone has some taste in the css colors, please suggest something! Currently, here is what I chose: