ppx_deriving 4.2.1 #10794
Merged
ppx_deriving 4.2.1 #10794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasche
force-pushed
the
ppx_deriving.4.2.1
branch
from
0931106 to
b28516b
Compare
✅ All lint checks passed 4edd1e4
✅ Installability check (7774 → 7775)
|
|
Is it expected that all the revdeps are failing with |
|
No, this is unexpected. |
gasche
force-pushed
the
ppx_deriving.4.2.1
branch
from
b28516b to
4edd1e4
Compare
This is a minor release on top of 4.2 (instead of a minor release on
top of 4.1 as was originally discussed). The goal is to release this
first, ask user feedback on whether it solves their issues, and make
a 4.1 maintenance release if the issues with driverification are still
there.
The changelog is as follows
* Add support for OCaml 4.06.0
ocaml-ppx/ppx_deriving#154, ocaml-ppx/ppx_deriving#155, ocaml-ppx/ppx_deriving#156, ocaml-ppx/ppx_deriving#159
(Gabriel Scherer, Fabian, Leonid Rozenberg)
* Consider { with_path = false } when printing record fields
ocaml-ppx/ppx_deriving#157
(François Pottier)
|
@mseri the tests seem to pass now. Does it look good to you? |
|
Looks good, thank you very much. I re-triggered one of the V2 builds that failed and looked spurious, just to double check if it fails again in the same way. After it's done I am happy to accept and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor release on top of 4.2 (instead of a minor release on
top of 4.1 as was originally discussed). The goal is to release this
first, ask user feedback on whether it solves their issues, and make
a 4.1 maintenance release if the issues with driverification are still
there.
The changelog is as follows
Add support for OCaml 4.06.0
make ppx_deriving 4.1 build under 4.05 ocaml-ppx/ppx_deriving#154, 4.06 support ocaml-ppx/ppx_deriving#155, 4.06 support for ppx_deriving 4.2 ocaml-ppx/ppx_deriving#156, free_vars_in_core_type and fold_{left,right}_type_decl now use
string lococaml-ppx/ppx_deriving#159(Gabriel Scherer, Fabian, Leonid Rozenberg)
Consider { with_path = false } when printing record fields
Modify ppx_deriving_show so that
{ with_path = false }is obeyed when printing record fields ocaml-ppx/ppx_deriving#157(François Pottier)