Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hpack < 0.13 is not compatible with OCaml 5.3 (compiler-libs change) #26538

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

kit-ty-kate
Copy link
Member

#=== ERROR while compiling hpack.0.12.0 =======================================#
# context              2.3.0~alpha~dev | linux/x86_64 | ocaml-variants.5.3.0+trunk | file:///home/opam/opam-repository
# path                 ~/.opam/5.3/.opam-switch/build/hpack.0.12.0
# command              ~/.opam/5.3/bin/dune build -p hpack -j 1 @install
# exit-code            1
# env-file             ~/.opam/log/hpack-20-a43dd2.env
# output-file          ~/.opam/log/hpack-20-a43dd2.out
### output ###
# (cd _build/default && /home/opam/.opam/5.3/bin/ocamlc.opt -w -40 -g -bin-annot -bin-annot-occurrences -I hpack/util/.gen_huffman.eobjs/byte -I /home/opam/.opam/5.3/lib/ocaml/compiler-libs -no-alias-deps -o hpack/util/.gen_huffman.eobjs/byte/dune__exe__Gen_huffman.cmo -c -impl hpack/util/gen_huffman.ml)
# File "hpack/util/gen_huffman.ml", line 113, characters 28-71:
# 113 |              [ Exp.constant (Pconst_integer (string_of_int code, None))
#                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# Error: This expression should not be a constructor, the expected type is
#        "Parsetree.constant"

This was temporary fixed in 0.13.0 by anmonteiro/ocaml-h2#251

@mseri
Copy link
Member

mseri commented Sep 14, 2024

Thanks

@mseri mseri merged commit b7a4744 into ocaml:master Sep 14, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants