Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yocaml is not compatible with the effect syntax #26548

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

kit-ty-kate
Copy link
Member

Reported upstream in xhtmlboi/yocaml#52

#=== ERROR while compiling yocaml.1.0.0 =======================================#
# context              2.3.0~alpha~dev | linux/x86_64 | ocaml-variants.5.3.0+trunk | file:///home/opam/opam-repository
# path                 ~/.opam/5.3/.opam-switch/build/yocaml.1.0.0
# command              ~/.opam/5.3/bin/dune build -p yocaml -j 1
# exit-code            1
# env-file             ~/.opam/log/yocaml-20-6964b3.env
# output-file          ~/.opam/log/yocaml-20-6964b3.out
### output ###
# (cd _build/default && /home/opam/.opam/5.3/bin/ocamldep.opt -modules -impl lib/yocaml/build.ml) > _build/default/lib/yocaml/.yocaml.objs/yocaml__Build.impl.d
# File "lib/yocaml/build.ml", line 192, characters 15-21:
# 192 | let collection effect arrow process =
#                      ^^^^^^
# Error: Syntax error
# (cd _build/default && /home/opam/.opam/5.3/bin/ocamldep.opt -modules -impl lib/yocaml/effect.ml) > _build/default/lib/yocaml/.yocaml.objs/yocaml__Effect.impl.d
# File "lib/yocaml/effect.ml", line 106, characters 34-40:
# 106 | let process_files paths predicate effect =
#                                         ^^^^^^
# Error: Syntax error
# (cd _build/default && /home/opam/.opam/5.3/bin/ocamldep.opt -modules -impl lib/yocaml/runtime.ml) > _build/default/lib/yocaml/.yocaml.objs/yocaml__Runtime.impl.d
# File "lib/yocaml/runtime.ml", line 93, characters 16-22:
# 93 |      fun resume effect -> resume $ perform effect
#                      ^^^^^^
# Error: Syntax error

@xvw
Copy link
Contributor

xvw commented Sep 12, 2024

Thanks @kit-ty-kate

We are currently rewriting YOCaml here: https://gitlab.com/funkywork/yocaml (and we will test it against 5.3 before the release). Should we change something to explain that the current version yocaml (1.x) is not compatible with 5.3?

@kit-ty-kate
Copy link
Member Author

Should we change something to explain that the current version yocaml (1.x) is not compatible with 5.3?

you can change the yocaml.opam file in your repository to add the missing conflict but that would only affect people who will try to pin your project with OCaml 5.3 so it's probably fine to just leave it like that while this is being fixed.

@avsm avsm merged commit 36d6bbd into ocaml:master Sep 12, 2024
3 checks passed
@avsm
Copy link
Member

avsm commented Sep 12, 2024

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants