Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liblinear 247 #26781

Merged
merged 17 commits into from
Nov 26, 2024
Merged

Liblinear 247 #26781

merged 17 commits into from
Nov 26, 2024

Conversation

UnixJunkie
Copy link
Contributor

No description provided.

@UnixJunkie
Copy link
Contributor Author

At install I get a permission denied at the cp stage (there are two). But I suspect this is due to my environment, not due to the opam package. If someone else could test this package, that would be helpful.

@UnixJunkie
Copy link
Contributor Author

related to #26774

@UnixJunkie
Copy link
Contributor Author

I'll try installing on the local disk as a test.

@UnixJunkie
Copy link
Contributor Author

I still have a copy error if installing on the local disk

@UnixJunkie
Copy link
Contributor Author

UnixJunkie commented Oct 25, 2024 via email

@mseri
Copy link
Member

mseri commented Oct 28, 2024

I was just suggesting it to see if it avoids the network disk issue

@UnixJunkie
Copy link
Contributor Author

There were some errors in the opam file (depexts instead of depends); my mistake.
But, I still get the error:

# install: cannot create regular file '~/.opam/4.14.1/bin/liblinear-train': Read-only file system

If someone can test on a computer that's not using NFS for the homedir, that might be helpful.

@UnixJunkie
Copy link
Contributor Author

UnixJunkie commented Oct 29, 2024 via email

@shonfeder
Copy link
Contributor

Is there an example of a .install file somewhere? I did not find in opam-repos.

Perhaps

extra-source "xmlm.install" {
src:
"https://raw.githubusercontent.com/ocaml/opam-source-archives/main/patches/xmlm/xmlm.install"
checksum: [
"sha256=5c91837e40cda04047271ed7a71360c00abb8fcbda9a4436d3baab320bc5246e"
"md5=17cae44846e3d0dbc0c4cb294723369b"
]
}
?

I am able to find many other examples in the opam repo using rg '\.install' too, in case that is helpful.

@mseri
Copy link
Member

mseri commented Nov 4, 2024

@UnixJunkie this works!!

@shonfeder
Copy link
Contributor

Are we OK to merge this one?

(the ci errors are inaccurate results due to some ongoing churn in the images).

@mseri
Copy link
Member

mseri commented Nov 6, 2024

Let’s wait a moment. @UnixJunkie does this version work with NFS?

@shonfeder
Copy link
Contributor

Kindly ping to, @UnixJunkie.

let's keep things simple
@UnixJunkie
Copy link
Contributor Author

This should be merged.
I know there is a problem w/ the NFS I am forced to use, but this has nothing to do w/ this clean opam package.
The fact that opam can install liblinear in user-space is a step forward to make packages relying on liblinear easier to install (there is the linwrap package for example).

@UnixJunkie
Copy link
Contributor Author

Once this is merged, I will replicate the recipe to create a user-space installer for libsvm.
For people who don't know, liblinear is kind of a chainsaw for machine-learning.
Libsvm is another very famous library (by the same author/research group at Taiwan national university) for the same kind of tasks, is a little bit slower but sometimes allows to get better models.

@shonfeder
Copy link
Contributor

Lovely. Thanks for all your work to make this available to the community!

@shonfeder shonfeder merged commit 6475c15 into ocaml:master Nov 26, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants