Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] git-kv (0.1.2) #27160

Merged
merged 2 commits into from
Dec 24, 2024
Merged

[new release] git-kv (0.1.2) #27160

merged 2 commits into from
Dec 24, 2024

Conversation

reynir
Copy link
Contributor

@reynir reynir commented Dec 20, 2024

A Mirage_kv implementation using git

CHANGES:
  • example app/mgit.exe: initialize the RNG and add an mtime repl command (!9 - @reynir, review by @hannesm)
  • BUG FIX: make last_modified return the commit date when on a clean commit.
    This restores the behavior before v0.1.0 (!10 - @reynir, review by @hannesm, @dinosaure)

CHANGES:

- example app/mgit.exe: initialize the RNG and add an mtime repl command (!9 - @reynir, review by @hannesm)
- **BUG FIX**: make `last_modified` return the commit date when on a clean commit.
  This restores the behavior before v0.1.0 (!10 - @reynir, review by @hannesm, @dinosaure)
@shonfeder
Copy link
Contributor

Looks like test failures on most platforms here. Looking like

#=== ERROR while compiling git-kv.0.1.2 =======================================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.5.0.0 | pinned(https://github.com/robur-coop/git-kv/releases/download/v0.1.2/git-kv-0.1.2.tbz)
# path                 ~/.opam/5.0/.opam-switch/build/git-kv.0.1.2
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p git-kv -j 255
# exit-code            1
# env-file             ~/.opam/log/git-kv-7-1d002c.env
# output-file          ~/.opam/log/git-kv-7-1d002c.out
### output ###
# File "test/dune", line 21, characters 7-12:
# 21 |  (name tests)
#             ^^^^^
# (cd _build/default/test && ./tests.exe)
# Testing `Git-KV alcotest tests'.
# This run has ID `DPVI1LGG'.
# 
#   [FAIL]        Basic tests          0   Read in change_and_push.
#   [OK]          Basic tests          1   Set outside change_and_push.
#   [FAIL]        Basic tests          2   Remove in change_and_push.
#   [OK]          Basic tests          3   Last modified in change_and_push.
#   [FAIL]        Basic tests          4   Digest in change_and_push.
#   [OK]          Basic tests          5   Multiple change_and_push.
# 
# ┌──────────────────────────────────────────────────────────────────────────────┐
# │ [FAIL]        Basic tests          0   Read in change_and_push.              │
# └──────────────────────────────────────────────────────────────────────────────┘
# [invalid] result is Error _
#           Raised at Stdlib.invalid_arg in file "stdlib.ml", line 30, characters 20-45
#           Called from Stdlib__Result.get_ok in file "result.ml" (inlined), line 21, characters 45-76
#           Called from Dune__exe__Tests.empty_repo in file "test/tests.ml", line 17, characters 12-60
#           Called from Dune__exe__Tests.read_in_change_and_push in file "test/tests.ml", line 29, characters 25-38
#           Called from Alcotest_engine__Core.Make.protect_test.(fun) in file "src/alcotest-engine/core.ml", line 186, characters 17-23
#           Called from Alcotest_engine__Monad.Identity.catch in file "src/alcotest-engine/monad.ml", line 24, characters 31-35
#           
# Logs saved to `~/.opam/5.0/.opam-switch/build/git-kv.0.1.2/_build/default/test/_build/_tests/Git-KV alcotest tests/Basic tests.000.output'.
#  ──────────────────────────────────────────────────────────────────────────────
# 
# 
# ┌──────────────────────────────────────────────────────────────────────────────┐
# │ [FAIL]        Basic tests          2   Remove in change_and_push.            │
# └──────────────────────────────────────────────────────────────────────────────┘
# ASSERT Store.get
# ASSERT Store.get
# [exception] Fun.Finally_raised: Unix.Unix_error(Unix.ESRCH, "kill", "")
#             Raised by primitive operation at Dune__exe__Tests.kill_git in file "test/tests.ml", line 21, characters 2-43
#             Called from Stdlib__Fun.protect.finally_no_exn in file "fun.ml", line 29, characters 8-18
#             Re-raised at Stdlib__Fun.protect.finally_no_exn in file "fun.ml", line 31, characters 6-57
#             Called from Stdlib__Fun.protect in file "fun.ml", line 34, characters 14-31
#             Called from Dune__exe__Tests.remove_in_change_and_push in file "test/tests.ml", line 83, characters 4-1023
#             Called from Stdlib__Result.bind in file "result.ml" (inlined), line 23, characters 36-39
#             Called from Dune__exe__Tests.remove_in_change_and_push in file "test/tests.ml", line 82, characters 4-1023
#             Called from Alcotest_engine__Core.Make.protect_test.(fun) in file "src/alcotest-engine/core.ml", line 186, characters 17-23
#             Called from Alcotest_engine__Monad.Identity.catch in file "src/alcotest-engine/monad.ml", line 24, characters 31-35
#             
# Logs saved to `~/.opam/5.0/.opam-switch/build/git-kv.0.1.2/_build/default/test/_build/_tests/Git-KV alcotest tests/Basic tests.002.output'.
#  ──────────────────────────────────────────────────────────────────────────────
# 
# 
# ┌──────────────────────────────────────────────────────────────────────────────┐
# │ [FAIL]        Basic tests          4   Digest in change_and_push.            │
# └──────────────────────────────────────────────────────────────────────────────┘
# ASSERT Store.digest
# ASSERT Store.digest
# ASSERT Store.digest
# [exception] Fun.Finally_raised: Unix.Unix_error(Unix.ESRCH, "kill", "")
#             Raised by primitive operation at Dune__exe__Tests.kill_git in file "test/tests.ml", line 21, characters 2-43
#             Called from Stdlib__Fun.protect.finally_no_exn in file "fun.ml", line 29, characters 8-18
#             Re-raised at Stdlib__Fun.protect.finally_no_exn in file "fun.ml", line 31, characters 6-57
#             Called from Stdlib__Fun.protect in file "fun.ml", line 34, characters 14-31
#             Called from Dune__exe__Tests.digest_in_change_and_push in file "test/tests.ml", line 152, characters 4-1023
#             Called from Stdlib__Result.bind in file "result.ml" (inlined), line 23, characters 36-39
#             Called from Dune__exe__Tests.digest_in_change_and_push in file "test/tests.ml", line 151, characters 4-1023
#             Called from Alcotest_engine__Core.Make.protect_test.(fun) in file "src/alcotest-engine/core.ml", line 186, characters 17-23
#             Called from Alcotest_engine__Monad.Identity.catch in file "src/alcotest-engine/monad.ml", line 24, characters 31-35
#             
# Logs saved to `~/.opam/5.0/.opam-switch/build/git-kv.0.1.2/_build/default/test/_build/_tests/Git-KV alcotest tests/Basic tests.004.output'.
#  ──────────────────────────────────────────────────────────────────────────────
# 
# Full test results in `~/.opam/5.0/.opam-switch/build/git-kv.0.1.2/_build/default/test/_build/_tests/Git-KV alcotest tests'.
# 3 failures! in 1.530s. 6 tests run.

Something that should be addressed before publishing?

@hannesm
Copy link
Member

hannesm commented Dec 23, 2024

The test errors are sandbox issues -- while testing we try to open a TCP listener (git daemon). I'll disable the tests for the release.

@mseri
Copy link
Member

mseri commented Dec 24, 2024

Thanks

@mseri mseri merged commit 8c99ffb into ocaml:master Dec 24, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants