Package ocaml-fsrs.0.1.0-alpha3

[chaosarium]

ocaml-fsrs.0.1.0-alpha3

OCaml implementation of the FSRS scheduler
A library implementing the FSRS (Free Spaced Repetition Scheduler) algorithm in OCaml.

---

• Homepage: https://github.com/chaosarium/ocaml-fsrs
• Source repo: git+https://github.com/chaosarium/ocaml-fsrs.git
• Bug tracker: https://github.com/chaosarium/ocaml-fsrs/issues

---

🐫 Pull-request generated by opam-publish v2.5.0

[ivnhk]

Hey @chaosarium

Thank you for the contribution

I see the following linter issues:

Error in ocaml-fsrs.0.1.0-alpha3: No package source directory provided.
Error in ocaml-fsrs.0.1.0-alpha3: error 60: Upstream check failed: "The archive doesn't match checksum:

Regarding the checksum, this is the respective error:

https://github.com/chaosarium/ocaml-fsrs/archive/refs/tags/0.1.0-alpha3.tar.gz (Bad checksum, expected sha256=e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855)
Error in ocaml-fsrs.0.1.0-alpha3:              error 60: Upstream check failed: "The archive doesn't match checksum:
                - archive: sha256=c59a658e8bb848e84df0e89703b1bde5199022ba1e682886fba93e8a401575c1, in opam file: sha256=e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
              ."

[ivnhk]

Suggested change

	checksum: "sha256=e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"
	checksum: "sha256=c59a658e8bb848e84df0e89703b1bde5199022ba1e682886fba93e8a401575c1"

[ivnhk]

Not sure that's what you need, but it'll fix the CI error related to the checksum

[ivnhk]

Additional question: do you plan to support Windows?

[ivnhk]

Would you like to specify a lower bound for ocaml dependency?

[yawaramin]

A few comments:

1. Can you remove the ocaml- prefix from the package name? See https://github.com/ocaml/opam-repository/tree/master/governance/policies#7-new-package-names-should-avoid-the-ocaml-prefixsuffix
2. Would you mind adding an interface file and docstrings for the library? Opam packages are built and their docs are published in the OCaml website. As it is right now this package will be published with only type signatures on the doc pages, which won't be a great user experience.
3. Would you mind using the full form of the terminology within the documentation itself so that users don't have to refer elsewhere to know what the package is and why they should use it? Eg it seems like 'FSRS' is a 'Free Spaced Repetition Scheduler' algorithm used by tools like Anki. It would be good to mention what this is and why/when to use it in the docs themselves.

[mseri]

Also please use ~alpha3 in your versioning: 0.1.0~alpha < 0.1.0 < 0.1.0-alpha