-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add conf-taglib_c #28001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EruEri
wants to merge
1
commit into
ocaml:master
Choose a base branch
from
EruEri:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add conf-taglib_c #28001
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| opam-version: "2.0" | ||
| maintainer: "https://github.com/ocaml/opam-repository/issues" | ||
| homepage: "https://taglib.org/" | ||
| bug-reports: "https://github.com/ocaml/opam-repository/issues" | ||
| authors: "taglib maintainers" | ||
| license: ["LGPL-2.1-or-later" "MPL-1.1"] | ||
| # https://www.mozilla.org/en-US/MPL/2.0/Revision-FAQ/#upgrading-someone-elses-code | ||
| build: ["pkg-config" "--atleast-version" "1.0.0" "--exists" "taglib_c"] | ||
| depends: [ | ||
| "conf-pkg-config" {build} | ||
| ] | ||
| depexts: [ | ||
| ["libtagc0-dev"] {os-family = "debian" | os-family = "ubuntu"} | ||
| ["taglib-dev"] {os-family = "alpine"} | ||
| ["libtag-devel"] {os-family = "suse" | os-family = "opensuse"} | ||
| ["taglib"] {os-family = "arch" | os = "freebsd" | os-distribution = "nixos"} | ||
| ["taglib"] {os = "macos" & os-distribution = "homebrew"} | ||
| ["taglib"] {os = "macos" & os-distribution = "macports"} | ||
| ["taglib-devel"] {os-distribution="centos" | os-family = "fedora"} | ||
| ] | ||
| synopsis: "Virtual package relying on taglib_c" | ||
| description: | ||
| "This package can only install if the taglib_c library is installed on the system." | ||
| flags: conf | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| opam-version: "2.0" | ||
| maintainer: "https://github.com/ocaml/opam-repository/issues" | ||
| homepage: "https://taglib.org/" | ||
| bug-reports: "https://github.com/ocaml/opam-repository/issues" | ||
| authors: "taglib maintainers" | ||
| license: ["LGPL-2.1-or-later" "MPL-1.1"] | ||
| # https://www.mozilla.org/en-US/MPL/2.0/Revision-FAQ/#upgrading-someone-elses-code | ||
|
|
||
| build: ["pkg-config" "--atleast-version" "2.0.0" "--exists" "taglib_c"] | ||
| depends: [ | ||
| "conf-pkg-config" {build} | ||
| ] | ||
| depexts: [ | ||
| ["libtag-c-dev"] { os-family = "ubuntu" } | ||
| ["taglib-dev"] {os-family = "alpine"} | ||
| ["libtag-devel"] {os-family = "suse" | os-family = "opensuse"} | ||
| ["taglib"] {os-family = "arch" | os = "freebsd" | os-distribution = "nixos"} | ||
| ["taglib"] {os = "macos" & os-distribution = "homebrew"} | ||
| ["taglib"] {os = "macos" & os-distribution = "macports"} | ||
| ] | ||
| synopsis: "Virtual package relying on taglib_c" | ||
| description: | ||
| "This package can only install if the taglib_c library is installed on the system." | ||
| flags: conf | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why there are less depexts than above?
I think
libtag-c-devshould be there for ubumtu for example: https://packages.ubuntu.com/plucky/libtag-c-devThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it not an issue that the package libtag-c-dev only seems to exist in the latest version of ubuntu (25.04) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I didn't know that the latest version of ubuntu had this version.
I removed fedora since the taglib package https://packages.fedoraproject.org/pkgs/taglib/taglib-devel/ doesn't provide the required version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or should I still put the package ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that is only in a recent version is not a problem, there is a way to filter the package name by os version in those cases: https://opam.ocaml.org/doc/Manual.html#opamvar-os-version
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So for packages not yet up to date into distribution repos, should I filter using the opam variable
os-version?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is a choice of name to be made, I'd say yes