Skip to content

[new release] mlx (2 packages) (0.10) #28058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2025
Merged

Conversation

andreypopp
Copy link
Member

OCaml syntax dialect which adds JSX syntax expressions

CHANGES:
  • compatibility with OCaml 5.3

CHANGES:

- compatibility with OCaml 5.3
@mseri
Copy link
Member

mseri commented Jun 21, 2025

Is the failure with 5.4~alpha1 something we should worry about and that should warrant an upper bound?

#=== ERROR while compiling mlx.0.10 ===========================================#
# context              2.3.0 | linux/x86_64 | ocaml-base-compiler.5.4.0~alpha1 | pinned(https://github.com/ocaml-mlx/mlx/releases/download/0.10/mlx-0.10.tbz)
# path                 ~/.opam/5.4~alpha1/.opam-switch/build/mlx.0.10
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p mlx -j 255 --promote-install-files=false @install
# exit-code            1
# env-file             ~/.opam/log/mlx-7-8c95d1.env
# output-file          ~/.opam/log/mlx-7-8c95d1.out
### output ###
# (cd _build/default && /home/opam/.opam/5.4~alpha1/bin/ocamlc.opt -w -40 -w -9-67 -open Astlib.Ast_501 -g -bin-annot -bin-annot-occurrences -I mlx/.pp.eobjs/byte -I /home/opam/.opam/5.4~alpha1/lib/ocaml-compiler-libs/common -I /home/opam/.opam/5.4~alpha1/lib/ocaml-compiler-libs/shadow -I /home/opam/.opam/5.4~alpha1/lib/ocaml/compiler-libs -I /home/opam/.opam/5.4~alpha1/lib/ppx_derivers -I /home/opam/.opam/5.4~alpha1/lib/ppxlib -I /home/opam/.opam/5.4~alpha1/lib/ppxlib/ast -I /home/opam/.opam/5.4~alpha1/lib/ppxlib/astlib -I /home/opam/.opam/5.4~alpha1/lib/ppxlib/print_diff -I /home/opam/.opam/5.4~alpha1/lib/ppxlib/stdppx -I /home/opam/.opam/5.4~alpha1/lib/ppxlib/traverse_builtins -I /home/opam/.opam/5.4~alpha1/lib/sexplib0 -I /home/opam/.opam/5.4~alpha1/lib/stdlib-shims -no-alias-deps -open Dune__exe -o mlx/.pp.eobjs/byte/dune__exe__Jsx_helper.cmo -c -impl mlx/jsx_helper.ml)
# File "mlx/jsx_helper.ml", line 27, characters 19-20:
# 27 |       String.equal a b && equal_longindent pa pb
#                         ^
# Error: The value a has type string Location.loc
#        but an expression was expected of type String.t = string
# (cd _build/default && /home/opam/.opam/5.4~alpha1/bin/ocamlopt.opt -w -40 -w -9-67 -open Astlib.Ast_501 -g -I mlx/.pp.eobjs/byte -I mlx/.pp.eobjs/native -I /home/opam/.opam/5.4~alpha1/lib/ocaml-compiler-libs/common -I /home/opam/.opam/5.4~alpha1/lib/ocaml-compiler-libs/shadow -I /home/opam/.opam/5.4~alpha1/lib/ocaml/compiler-libs -I /home/opam/.opam/5.4~alpha1/lib/ppx_derivers -I /home/opam/.opam/5.4~alpha1/lib/ppxlib -I /home/opam/.opam/5.4~alpha1/lib/ppxlib/ast -I /home/opam/.opam/5.4~alpha1/lib/ppxlib/astlib -I /home/opam/.opam/5.4~alpha1/lib/ppxlib/print_diff -I /home/opam/.opam/5.4~alpha1/lib/ppxlib/stdppx -I /home/opam/.opam/5.4~alpha1/lib/ppxlib/traverse_builtins -I /home/opam/.opam/5.4~alpha1/lib/sexplib0 -I /home/opam/.opam/5.4~alpha1/lib/stdlib-shims -intf-suffix .ml -no-alias-deps -open Dune__exe -o mlx/.pp.eobjs/native/dune__exe__Ast_helper.cmx -c -impl mlx/ast_helper.ml)
# File "mlx/ast_helper.ml", line 96, characters 31-47:
# 96 |         | Ptyp_constr( { txt = Longident.Lident s }, [])
#                                     ^^^^^^^^^^^^^^^^
# Error: The constructor Longident.Lident belongs to the variant type
#          Longident.t
#        but a constructor was expected belonging to the variant type
#          Astlib__.Longident.t = Astlib__.Longident.t

@andreypopp
Copy link
Member Author

added the upper bound, seems like it is only failing on freebsd (which is experimental), ok to merge?

@mseri
Copy link
Member

mseri commented Jun 23, 2025

Thanks

@mseri mseri merged commit 8e38b52 into ocaml:master Jun 23, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants