Skip to content

Conversation

oliverfriedmann
Copy link
Contributor

A multi-purpose library for OCaml

CHANGES:
  • Change name to tcs-lib

@oliverfriedmann
Copy link
Contributor Author

Warning in tcs-lib.0.6: Possible name collision with package 'TCSLib' - this is on purpose - the old name is causing issues with dune in projects including it

Copy link
Member

@jmid jmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 👍
CI is indeed only failing with the name collision warning.

Would you consider adding an x-maintenance-intent entry?
https://github.com/ocaml/opam-repository/blob/master/governance/policies/archiving.md

@jmid jmid added the question label Sep 24, 2025
@oliverfriedmann
Copy link
Contributor Author

thanks!

re: maintenance intent - you mean for the prior versions? they are still referenced though by prior versions of other packages

@jmid
Copy link
Member

jmid commented Sep 24, 2025

re: maintenance intent - you mean for the prior versions? they are still referenced though by prior versions of other packages

Indeed, but with, e.g., pgsolver.4.3 needing "TCSLib" {>= "0.2" & < "0.5"} that would in principle still allow for archiving TCSLib.0.{1,2,5} and keeping TCSLib.0.3 and tcs-lib.0.6, assuming you intend to only maintain (latest)... 🤷

For a start, I think just adding an entry for this tcs-lib.0.6 would be OK.

I don't believe the tooling for archiving supports renamed packages, so even if you add an entry for the TCSLib-named ones, a bit of manual intervention is probably needed.
Polite ping to @hannesm who has been leading the archiving process.

@oliverfriedmann
Copy link
Contributor Author

got it - so just to clarify, I would simply add x-maintenance-intent: latest to tcs-lib v0.6?

@jmid
Copy link
Member

jmid commented Sep 25, 2025

got it - so just to clarify, I would simply add x-maintenance-intent: latest to tcs-lib v0.6?

Yes, that would be great! The concrete syntax is x-maintenance-intent: ["(latest)"].
Since you seem to generate your opam-file from dune-project adding an (maintenance_intent "(latest)") entry to (package ...) and running dune build tcs-lib.opam should do it.

I'll let @hannesm decide how he would prefer handling such entries in connection with the package renaming.

@hannesm
Copy link
Member

hannesm commented Sep 25, 2025

From my perspective, if I understand you correctly:

  • there's a new tcs-lib here (and x-maintenance-intent: [ "(latest)" ] is fine for it)
  • there's a no-longer-maintained TCSLib, adding a x-maintenance-intent: [ "(none)" ] would be good for it.

About the latter: as long as there are packages that need TCSLib which are not scheduled for archival, the required TCSLib versions will be retained. So putting that x-maintenance-intent won't lead to pgsolver becoming uninstallable.

CHANGES:

- Change name to tcs-lib
@oliverfriedmann
Copy link
Contributor Author

Updated the PR for tcs-lib v0.6 - for the existing versions of TCSLib, should I add the x-maintenance-intent: [ "(none)" ] to every single version of it?

@hannesm
Copy link
Member

hannesm commented Sep 25, 2025

Updated the PR for tcs-lib v0.6 - for the existing versions of TCSLib, should I add the x-maintenance-intent: [ "(none)" ] to every single version of it?

It is sufficient to add it to the latest release.

@oliverfriedmann
Copy link
Contributor Author

done

Copy link
Member

@jmid jmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
CI is down to failing with a name clash warning about the two similar names 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants