-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[new release] tcs-lib (0.6) #28573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[new release] tcs-lib (0.6) #28573
Conversation
Warning in tcs-lib.0.6: Possible name collision with package 'TCSLib' - this is on purpose - the old name is causing issues with dune in projects including it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM 👍
CI is indeed only failing with the name collision warning.
Would you consider adding an x-maintenance-intent
entry?
https://github.com/ocaml/opam-repository/blob/master/governance/policies/archiving.md
thanks! re: maintenance intent - you mean for the prior versions? they are still referenced though by prior versions of other packages |
Indeed, but with, e.g., For a start, I think just adding an entry for this I don't believe the tooling for archiving supports renamed packages, so even if you add an entry for the |
got it - so just to clarify, I would simply add x-maintenance-intent: latest to tcs-lib v0.6? |
Yes, that would be great! The concrete syntax is I'll let @hannesm decide how he would prefer handling such entries in connection with the package renaming. |
From my perspective, if I understand you correctly:
About the latter: as long as there are packages that need |
CHANGES: - Change name to tcs-lib
117bc7d
to
2e6697e
Compare
Updated the PR for tcs-lib v0.6 - for the existing versions of TCSLib, should I add the x-maintenance-intent: [ "(none)" ] to every single version of it? |
It is sufficient to add it to the latest release. |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
CI is down to failing with a name clash warning about the two similar names 🙂
A multi-purpose library for OCaml
CHANGES: