Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all archives are retrieved in make cache-archives #5624

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Aug 3, 2023

Small fix for 2.1 only - the full tarball doesn't include the 0install solver. master/2.2 isn't affected by this.

@dra27
Copy link
Member Author

dra27 commented Nov 14, 2023

Repository SHA for the various tests updated, so GHA at least passes. AppVeyor is failing from the good ol' timeouts from the 2.1 reftests. No idea what to do about the ocaml-benchmarks failure!

Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rjbou
Copy link
Collaborator

rjbou commented Nov 14, 2023

there is no benchmarks on 2.1 branch, and from what i know it is not possible to select on which jobs/branch launch the benchmarks.

@kit-ty-kate kit-ty-kate added this to the 2.1.7 milestone Jul 16, 2024
@rjbou rjbou requested a review from kit-ty-kate July 24, 2024 15:14
Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested using the release script. The new archive contains as expected: ocaml, flexdll, mccs, 0install and opam-0install-cudf

@rjbou rjbou merged commit 66f7251 into ocaml:2.1 Jul 24, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants