-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.1.6 backport commits #5870
Merged
Merged
2.1.6 backport commits #5870
Commits on May 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 736e30b - Browse repository at this point
Copy the full SHA 736e30bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5954f9b - Browse repository at this point
Copy the full SHA 5954f9bView commit details -
Better recognize depexts on Gentoo, NetBSD, OpenBSD
Gentoo, NetBSD, and OpenBSD name packages in a /-separated hierarchy. For example, libgmp is available as "dev-libs/gmp" (on Gentoo[1]) or "devel/gmp" (on NetBSD[2], or OpenBSD[3]). The first fix in this commit (the change to the `short_name` function) removes the leading "/" from the package's short name. Prior to this commit, if `pkg` were "dev-libs/gmp", then `short_name` would be "/gmp". That doesn't match the depext name of "gmp" so opam thought the package wasn't installed. OpenBSD also uses flavors and subpackages[4] in some of its package names. For example, OpenBSD has two subpackages for the "devel/gmp" package: main and cxx. That means that the full name for libgmp on OpenBSD is likely to be "devel/gmp,-main". Prior to this commit, `short_name` for this package was "gmp,-main". This commit introduces `no_flavor` which removes the flavors and subpackages from package names, if present. That causes "devel/gmp,-main" on OpenBSD to have a `no_flavor` name of "gmp". This name matches the depext name, so that opam recognizes that libgmp is installed. 1: https://packages.gentoo.org/packages/dev-libs/gmp 2: https://cdn.netbsd.org/pub/pkgsrc/current/pkgsrc/devel/gmp/index.html 3: https://github.com/openbsd/ports/tree/b12d29201e832eb5a230d54449ff2a13502c9fbb/devel/gmp 4: https://man.openbsd.org/OpenBSD-7.0/pkgpath.7
Configuration menu - View commit details
-
Copy full SHA for 42f6933 - Browse repository at this point
Copy the full SHA 42f6933View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f2e2f9 - Browse repository at this point
Copy the full SHA 1f2e2f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86379a9 - Browse repository at this point
Copy the full SHA 86379a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2760fd4 - Browse repository at this point
Copy the full SHA 2760fd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c08c3e - Browse repository at this point
Copy the full SHA 7c08c3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 049639c - Browse repository at this point
Copy the full SHA 049639cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 392c4a9 - Browse repository at this point
Copy the full SHA 392c4a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e074e6e - Browse repository at this point
Copy the full SHA e074e6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c56d64 - Browse repository at this point
Copy the full SHA 6c56d64View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9fae98 - Browse repository at this point
Copy the full SHA d9fae98View commit details -
Configuration menu - View commit details
-
Copy full SHA for a47c3bd - Browse repository at this point
Copy the full SHA a47c3bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c47ee00 - Browse repository at this point
Copy the full SHA c47ee00View commit details -
Configuration menu - View commit details
-
Copy full SHA for d614bfa - Browse repository at this point
Copy the full SHA d614bfaView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.