-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depext: Add Altlinux family support #6207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR.
This change looks reasonable modulo the one suggestion.
If you have some spare time, would you be able to add altlinux to our testsuite? (see the files .github/workflows/depexts.yml
and .github/scripts/depexts/generate-actions.sh
) It should just be a case of either merging the debian and altlinux case or copy-pasting. Altlinux is available as alt
on Docker Hub.
If you don't have time we'll do it at some point in the future
using rpm for a package manager and apt-rpm (fork of the apt fron debian wuth RPM support) for the repository manager.
f7b3cc0
to
2780d9c
Compare
It is not possible ftm to add a depext test as it there is no conf package that have Altlinux support on main opam repository. A PR is added for when it will be the case #6277 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR
Thanks! |
Thank you very much for the merging, unfortunately I could not get to the Docker and make tests for altlinux, but I remember about this task. |
No worries, the docker test PR is already opened, see #6207 (comment) |
using rpm for a package manager and apt-rpm (fork of the apt fron debian wuth RPM support) for the repository manager.