Add OCaml 5.2.0 to the build matrix and update the vendored dependencies to fix compilation with OCaml 5.3 #6211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
commented
Sep 30, 2024
| "5.0.0"; "5.1.1"; "5.2.0"; | ||
|
|
||
| (* The last elements of the list after 4.14 will be used as default versions *) | ||
| "4.14.1"; |
There was a problem hiding this comment.
Suggested change
| "4.14.1"; | |
| "4.14.2"; |
rjbou
reviewed
Sep 30, 2024
| @@ -65,7 +69,7 @@ let end_workflow ~oc:_ ~workflow:_ = () | |||
| let ocamls = | |||
| List.map (fun v -> Scanf.sscanf v "%u.%u.%u" (fun major minor _ -> ((major, minor), v))) ocamls | |||
|
|
|||
| let latest_ocaml = List.fold_left (fun _ (v, _) -> v) (0, 0) ocamls | |||
| let latest_ocaml = (4, 14) | |||
There was a problem hiding this comment.
The variable should be renamed to reflect its new usage
|
Merged into #6216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the vendored dependencies were updated except
rewhile ocaml/ocaml-re#411 is being delt with.This PR is a split from #6192 while i'm trying to figure out why the Github Action scripts do not like OCaml 5.3.0~alpha1