Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the installation documentation #6372

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

kit-ty-kate
Copy link
Member

@kit-ty-kate kit-ty-kate commented Jan 20, 2025

While reviewing #6367 i realized the installation documentation is outdated and would require constant update not to be.

This PR does:

  • Replace the individual badge for each distribution&version by repology's vertical-allrepos with its exclude_unsupported=1 option (see https://repology.org/project/referencing/badges) to only show the distribution version not EoL.
  • Remove Exherbo from the list of supported distribution as it only provides the 11 years out-of-date opam 1.1.1
  • Add Alpine Linux to the list
  • Merge the Debian and Ubuntu steps
  • Remove mentions of CentOS and RHEL which do not have the opam package
  • Remove the Distribution.md file which is extremely out-of-date, redundant with the new automatically generated repology badge and requires a huge effort to maintain

as well as some general fixes and improvements

@kit-ty-kate kit-ty-kate added this to the 2.4.0~alpha1 milestone Jan 20, 2025
@kit-ty-kate kit-ty-kate requested a review from rjbou January 21, 2025 21:05
@kit-ty-kate kit-ty-kate force-pushed the improve-install-doc branch 2 times, most recently from fb3848e to eccd467 Compare January 24, 2025 23:24
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should contains the details that is in the first comment


#### Arch Linux
[![repology package status](https://repology.org/badge/vertical-allrepos/opam.svg?exclude_unsupported=1)](https://repology.org/project/opam/versions)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list is quite long, i'm not sure that it should here but it's better than at the end i think...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes much more sense at the beginning rather than the end.
The way users read it is:

  1. what system do i have?
  2. is the system package up-to-date?
  • If yes use that one (if you don't know how, the list would be right after)
  • If not, then the section just before on the binary installer will do

The per-distribution list is only useful for a minority of people (beginners), whereas the repology list is useful much more often in my opinion

doc/pages/Install.md Outdated Show resolved Hide resolved
* Replace the individual badge for each distribution&version by repology's vertical-allrepos with its exclude_unsupported=1 option (see https://repology.org/project/referencing/badges) to only show the distribution version not EoL.
* Remove Exherbo from the list of supported distribution as it only provides the 11 years out-of-date opam 1.1.1
* Add Alpine Linux to the list
* Merge the Debian and Ubuntu steps
* Remove mentions of CentOS and RHEL which do not have the opam package
* Remove the Distribution.md file which is extremely out-of-date, redundant with the new automatically generated repology badge and requires a huge effort to maintain
@rjbou rjbou merged commit 34b7b4e into ocaml:master Feb 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants